Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move][framework] Enable building framework with move-2 #14917

Open
wants to merge 1 commit into
base: igor/ungate_native_memory_operations
Choose a base branch
from
Open

[move][framework] Enable building framework with move-2 #14917

wants to merge 1 commit into from

Conversation

igor-aptos
Copy link
Contributor

To be landed for the release we are ready to do so.

(#14877 mistakenly got closed)

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@igor-aptos igor-aptos added CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Oct 9, 2024
@trunk-io Trunk.io
Copy link

trunk-io bot commented Oct 9, 2024 •
edited
Loading

⏱️ 8h 18m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 4h 39m 🟥 🟥 🟥 🟥 🟩 (+3 more)
execution-performance / test-target-determinator 31m 🟩 🟩 🟩 🟩 🟩 (+3 more)
test-target-determinator 20m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-unit-coverage 16m 🟩 
rust-move-unit-coverage 16m 🟩 
rust-move-unit-coverage 15m 🟩 
rust-move-unit-coverage 12m 🟩 
rust-move-unit-coverage 11m 🟩 
rust-cargo-deny 11m 🟩 🟩 🟩 🟩 🟩 (+1 more)
check-dynamic-deps 11m 🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-move-unit-coverage 10m ⬜ 
rust-move-tests 10m 🟩 
rust-move-tests 10m 🟩 
rust-move-tests 10m 🟥 
rust-move-tests 10m 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 34m 20m +68%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.78571% with 55 lines in your changes missing coverage. Please review.

Project coverage is 57.5%. Comparing base (a5af4dc) to head (7a83ca1).

Files with missing lines Patch % Lines
third_party/move/move-vm/types/src/value_serde.rs 0.0% 34 Missing ⚠️
...ptos-move/framework/move-stdlib/src/natives/bcs.rs 4.7% 20 Missing ⚠️
aptos-move/framework/src/aptos.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@                         Coverage Diff                          @@
##           igor/use_native_vector_move_range   #14917     +/-   ##
====================================================================
- Coverage                               60.1%    57.5%   -2.7%     
====================================================================
  Files                                    858      858             
  Lines                                 211455   211510     +55     
====================================================================
- Hits                                  127237   121651   -5586     
- Misses                                 84218    89859   +5641

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 6046016 to c5e50b3 Compare October 10, 2024 00:08
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 5394fb5 to 927268c Compare October 10, 2024 00:08
@msmouse
Copy link
Contributor

msmouse commented Oct 10, 2024

what resulted in the documentation changes?

@igor-aptos
Copy link
Contributor Author

@msmouse I assume new compiler outputs slightly different documentation

@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from c5e50b3 to 36f8618 Compare October 10, 2024 18:10
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 927268c to 816d850 Compare October 10, 2024 18:10
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 36f8618 to 9851f51 Compare October 15, 2024 19:48
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 816d850 to 500a48d Compare October 15, 2024 19:48
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 9851f51 to 3bcedb1 Compare October 16, 2024 21:07
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 500a48d to e35f0c1 Compare October 16, 2024 21:07
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 3bcedb1 to a5af4dc Compare October 16, 2024 21:17
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from e35f0c1 to 7a83ca1 Compare October 16, 2024 21:18
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from a5af4dc to 9fcf365 Compare October 21, 2024 23:10
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 7a83ca1 to 9994879 Compare October 21, 2024 23:11
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 9fcf365 to 53920f9 Compare November 8, 2024 23:25
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 9994879 to 686d2de Compare November 8, 2024 23:27
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 53920f9 to 58c55c0 Compare November 9, 2024 00:17
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 83e27b8 to f72afc4 Compare November 19, 2024 20:42
@igor-aptos Graphite App
Copy link
Contributor Author

igor-aptos commented Nov 19, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 19, 2024
Merged
Merged
Open
Open
Open
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 2bdb8c9 to 878a3a2 Compare November 23, 2024 02:48
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from f72afc4 to 07bad73 Compare November 23, 2024 02:48
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch from 878a3a2 to aa0753b Compare December 3, 2024 17:06
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 07bad73 to f474595 Compare December 3, 2024 17:07
@igor-aptos igor-aptos force-pushed the igor/use_native_vector_move_range branch 3 times, most recently from afa6bd2 to 0fe0e4c Compare December 6, 2024 00:50
Base automatically changed from igor/use_native_vector_move_range to main December 6, 2024 02:01
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from f474595 to 9dbf014 Compare December 6, 2024 21:11
@igor-aptos igor-aptos changed the base branch from main to igor/ungate_native_memory_operations December 6, 2024 21:11
This was referenced Dec 6, 2024
Open
Draft
@igor-aptos
[move][framework] Enable building framework with move-2
5600805 
To be landed for the release we are ready to do so.
@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from fa59933 to d5b3656 Compare December 12, 2024 18:24
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 9dbf014 to 5600805 Compare December 12, 2024 18:24
This was referenced Dec 12, 2024
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@msmouse msmouse Awaiting requested review from msmouse

@lightmark lightmark Awaiting requested review from lightmark

@grao1991 grao1991 Awaiting requested review from grao1991

@zekun000 zekun000 Awaiting requested review from zekun000

@vgao1996 vgao1996 Awaiting requested review from vgao1996

@georgemitenkov georgemitenkov Awaiting requested review from georgemitenkov

Assignees
No one assigned
Labels
CICD:run-execution-performance-full-test Run execution performance test (full version) CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-aptos @msmouse